Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7435 D8CORE-7436 | configure card and list display #814

Conversation

rebeccahongsf
Copy link
Contributor

@rebeccahongsf rebeccahongsf commented Sep 18, 2024

READY FOR REVIEW

Summary

  • D8CORE-7435 | configure card display(s)
  • D8CORE-7436 | configure list display(s)

Review By (Date)

  • When possible

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Create a page with an opportunities card
  4. Verify that the layout structure matches the figma wireframe screenshot in JIRA
  5. Create a page with a list containing opportunities
  6. Verify that the layout structure matches what is outlined in JIRA
  7. Review code

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? Yes

Associated Issues and/or People

  • D8CORE-7435
  • D8CORE-7435

@rebeccahongsf rebeccahongsf changed the title D8CORE-7435 | configure card display D8CORE-7435 | configure card and list display Sep 18, 2024
@rebeccahongsf rebeccahongsf changed the title D8CORE-7435 | configure card and list display D8CORE-7435 D8CORE-7436 | configure card and list display Sep 18, 2024
Copy link
Contributor

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is close, but the base branch needs some work. You can merge them all into one if that makes it easier for you to iterate on.

- text
- user
id: node.stanford_opportunity.teaser
targetEntityType: node
bundle: stanford_opportunity
mode: teaser
content:
body:
type: text_summary_or_trimmed
su_opp_application_deadline:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to configure the teaser display which will be the "List" display?

type: entity_reference_label
label: hidden
settings:
link: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to link to the sponsor taxonomy term.

type: entity_reference_label
label: hidden
settings:
link: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe wet want to link to the taxonomy term.

type: entity_reference_label
label: hidden
settings:
link: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe wet want to link to the taxonomy term.

type: entity_reference_label
label: hidden
settings:
link: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to link to the sponsor taxonomy term.

@rebeccahongsf
Copy link
Contributor Author

This PR is close, but the base branch needs some work. You can merge them all into one if that makes it easier for you to iterate on.

I'll do just that and merge this PR in. Changes to be implemented in #813 😉 Thank you for the speedy review, Mike!

@rebeccahongsf rebeccahongsf merged commit e163d96 into feature/D8CORE-7434-oppNodeDisplay Sep 18, 2024
4 of 7 checks passed
@rebeccahongsf rebeccahongsf deleted the feature/D8CORE-7435--oppCardDisplay branch September 18, 2024 16:46
pookmish pushed a commit that referenced this pull request Oct 15, 2024
* D8CORE-7435 | configure card display

* D8CORE-7436 | configure teaser and search index display
pookmish pushed a commit that referenced this pull request Nov 4, 2024
* D8CORE-7435 | configure card display

* D8CORE-7436 | configure teaser and search index display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants